Include embedder SDK libraries only if the default library is SDK library too. #1962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@devoncarew: could you give me some pointers why the test fail and how it could be related to my changes? |
Collaborator
Author
|
Closing this as this seems to be the wrong approach. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good part of the code is refactoring, and the main addition is the
packageGraph.packageMeta.isSdkcondition.I believe this addresses #1949 and dart-lang/pub-dev#2108.
I was able to try and validate it on: a Dart package, on a Flutter package, on the Dart SDK, however, I was not able to verify it on the Flutter SDK (not sure how to generate docs for it).